deploy the docs app from a PR to gh-pages #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
balzss
force-pushed
the
test/gh-pages-preview
branch
from
d24ea2b
to
7dfc794
Compare
balzss
changed the title
matyasf
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
nice work!
in the future we could exclude some paths that dont affect the docs build, e.g. test folders, Storybook folders, regression test https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths
joyenjoyer
approved these changes
Jul 23, 2024
balzss
force-pushed
the
test/gh-pages-preview
branch
from
7dfc794
to
f9c31a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4139
this pr creates 2 new actions:
gh-pagesgh-pages(note that this doesn't replace instructure.design and only creates a parallel copy with the url https://instructure.github.io/instructure-ui/; a full replacement needs some additional things like the legacy docs and should be done in a separate ticket)
this pr also removes a part of the pr validation action (which runs the unit tests) which builds and deploys the docs to netlify